Skip to content

feat(combo): expose input to set groups sorting order #10286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 25, 2021
Merged

feat(combo): expose input to set groups sorting order #10286

merged 7 commits into from
Oct 25, 2021

Conversation

viktorkombov
Copy link
Contributor

Closes #10125

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@viktorkombov viktorkombov requested review from Lipata and wnvko October 12, 2021 14:34
@viktorkombov viktorkombov added ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 12, 2021
wnvko
wnvko requested changes Oct 13, 2021
View reviewed changes
wnvko
wnvko previously approved these changes Oct 14, 2021
View reviewed changes
Lipata
Lipata requested changes Oct 18, 2021
View reviewed changes
@viktorkombov viktorkombov requested review from Lipata and wnvko October 20, 2021 09:12
wnvko
wnvko previously approved these changes Oct 20, 2021
View reviewed changes
Lipata
Lipata previously approved these changes Oct 21, 2021
View reviewed changes
@Lipata Lipata added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 21, 2021
@ddaribo ddaribo added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 22, 2021
@viktorkombov viktorkombov dismissed stale reviews from Lipata and wnvko via 3aaa5d2 October 22, 2021 13:36
@viktorkombov viktorkombov requested review from Lipata and wnvko October 22, 2021 13:37
@ddaribo ddaribo removed the 💥 status: in-test PRs currently being tested label Oct 25, 2021
@ddaribo ddaribo added the ✅ status: verified Applies to PRs that have passed manual verification label Oct 25, 2021
@zdrawku zdrawku merged commit 3ddcff8 into master Oct 25, 2021
@zdrawku zdrawku deleted the vkombov/feat-10125-master branch October 25, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

@wnvko wnvko wnvko approved these changes

Assignees

@ddaribo ddaribo

Labels
combo version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IgxCombo: being able to set groups sorting order
6 participants
@viktorkombov @Lipata @wnvko @zdrawku @ddaribo @kdinev